-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](fe) modify tablet cooldownConfLock to reduce memory #59356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR optimizes memory usage in the Tablet class by replacing MonitoredReentrantReadWriteLock with a simple Object for the cooldownConfLock synchronization mechanism.
Key Changes:
- Replaced
MonitoredReentrantReadWriteLockwithObjectfor cooldownConfLock to reduce memory footprint - Converted write lock operations in
setCooldownConf()to use synchronized block - Converted read lock operations with try-finally in
getCooldownConf()to use synchronized block
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
run buildall |
TPC-H: Total hot run time: 34913 ms |
TPC-DS: Total hot run time: 180017 ms |
ClickBench: Total hot run time: 27.04 s |
FE UT Coverage ReportIncrement line coverage |
FE Regression Coverage ReportIncrement line coverage |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
deardeng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
the usage of
cooldownConfLockis simple, does not need ReentrantReadWriteLock because it cost too much memory, especially when a cluster has many tablets.before:

after:

Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)