Skip to content

[Fix](cloud-mow) Fix Fe memory leak due to txnLastSignatureMap #59385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dataroaring merged 1 commit into from
Dec 26, 2025
Merged

[Fix](cloud-mow) Fix Fe memory leak due to txnLastSignatureMap #59385

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions fe/fe-core/src/main/java/org/apache/doris/cloud/transaction/CloudGlobalTransactionMgr.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,6 +425,8 @@ public void commitTransactionWithoutLock(long dbId, List<Table> tableList, long
}
commitTransactionWithoutLock(dbId, tableList, transactionId, tabletCommitInfos, txnCommitAttachment, false,
mowTableList, backendToPartitionInfos);
// clear signature after commit succeeds
clearTxnLastSignature(dbId, transactionId);
} catch (Exception e) {
if (!mowTableList.isEmpty()) {
LOG.warn("commit txn {} failed, release delete bitmap lock, catch exception {}", transactionId,
Expand Down Expand Up @@ -1491,6 +1493,8 @@ public boolean commitAndPublishTransaction(DatabaseIf db, long transactionId,
}
commitTransactionWithSubTxns(db.getId(), tableList, transactionId, subTransactionStates, mowTableList,
backendToPartitionInfos);
// clear signature after commit succeeds
clearTxnLastSignature(db.getId(), transactionId);
} catch (Exception e) {
if (!mowTableList.isEmpty()) {
LOG.warn("commit txn {} failed, release delete bitmap lock, catch exception {}", transactionId,
Expand Down Expand Up @@ -1671,6 +1675,8 @@ public boolean commitAndPublishTransaction(DatabaseIf db, List<Table> tableList,
beforeCommitTransaction(tableList, transactionId, timeoutMillis);
try {
commitTransactionWithoutLock(db.getId(), tableList, transactionId, tabletCommitInfos, txnCommitAttachment);
// Only clear signature after commit succeeds, as BE may retry on failure
clearTxnLastSignature(db.getId(), transactionId);
} finally {
stopWatch.stop();
long costTimeMs = stopWatch.getTime();
Expand Down Expand Up @@ -1738,6 +1744,7 @@ public void abortTransaction(Long dbId, Long transactionId, String reason,
abortTxnResponse = abortTransactionImpl(dbId, transactionId, reason, null);
} finally {
handleAfterAbort(abortTxnResponse, txnCommitAttachment, transactionId);
clearTxnLastSignature(dbId, transactionId);
}
}

Expand Down