fix: projections on base table columns result in failed indexing when using unzipped segments#19662
Open
capistrant wants to merge 2 commits into
Open
fix: projections on base table columns result in failed indexing when using unzipped segments#19662capistrant wants to merge 2 commits into
capistrant wants to merge 2 commits into
Conversation
clintropolis
reviewed
Jul 7, 2026
| // outputName can carry a bundle-prefixed logical name (e.g. "__base/<col>"); flatten any separators so the scratch | ||
| // dir stays a single flat entry under segmentBaseDir rather than creating an intermediate subdirectory that would | ||
| // be orphaned when the leaf is deleted (and later rejected by the v10 flat-directory no-zip segment push path). | ||
| final File tmpOutputFilesDir = new File(segmentBaseDir, "tmp_" + outputName.replace('/', '_') + "_merger"); |
Member
There was a problem hiding this comment.
i think instead of flattening, I think it would probably be safer to try to delete the whole path we created if non-empty (so in PersistedIdConversions#close).
There is some code that does this in SegmentLocalCacheManager#cleanupLegacyCacheLocation, which recursively deletes its way back up to some base path, which i think could be moved to FileUtils or something.
Create a static file utils method for recursively deleting a target dir as well as any empty anscestors.
clintropolis
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Was experimenting locally while reviewing #19657 and ran into ingest failures when running the wikipedia batch ingestion example with a rollup projection added on
isRobotcolumn.Release note
n/a
Key changed/added classes in this PR
DictionaryEncodedColumnMergerThis PR has: