refactor: switch diskNormalized strategy to be more tune-able#19663
Merged
Conversation
FrankChen021
reviewed
Jul 8, 2026
FrankChen021
left a comment
Member
There was a problem hiding this comment.
I have reviewed the code for correctness, edge cases, concurrency, and integration risks; no issues found.
Reviewed 7 of 7 changed files.
This is an automated review by Codex GPT-5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Goal here is to make the
diskNormalizedstrategy more tunable. Given the new, working version has not yet been included in a major release I've done some refactoring to make things easier to tune based on experience of running this in production.The primary changes are making the utilizationThreshold more intuitive: increasing the threshold increases the "tolerance" of the strategy, while decreasing pushes nodes' disk utilization closer together. Prior to these changes, the tuning of the threshold config wasn't as straightforward and could result in under/over-aggressive segment movement. With these changes, you can expect the config value to be approximately equal to the absolute difference between the min/max disk utilized servers' utilization within a tier.
Release note
Make the diskNormalized strategy more tunable. The primary changes are making the utilizationThreshold more intuitive: increasing the threshold increases the "tolerance" of the strategy, while decreasing pushes nodes' disk utilization closer together.
This PR has: