fix: console bugs and ci problems #1397
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request addresses console-related fixes for the Dubbo Admin project. The changes primarily focus on configuration management, observability features, logging improvements, and code cleanup.
Changes:
- Fixed configuration structure by separating observability settings from console configuration and adding proper validation
- Corrected logger initialization to support file output with rotation and improved configuration
- Cleaned up unused code files and consolidated version management
Reviewed changes
Copilot reviewed 42 out of 232 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| release/kubernetes/dubbo-samples-shop/dubbo-samples-shop-all.yaml | Added tracing sampling probability configuration (contains critical spelling error) |
| pkg/version/version.go | Reorganized version information structure and fixed variable naming |
| pkg/version/compatibility.go | Removed unused compatibility checking code |
| pkg/version/cobra.go | Removed unused version structure |
| pkg/governor/nacos2/governor.go | Added synchronization delays for config operations |
| pkg/engine/kubernetes/listerwatcher/runtime_instance.go | Added nil checks and fixed identifier naming |
| pkg/discovery/nacos2/listerwatcher/*.go | Added client cleanup in Stop methods |
| pkg/core/logger/log.go | Refactored logging to support both console and file output with rotation |
| pkg/core/*.go | Removed alias helper functions |
| pkg/console/service/*.go | Added observability dashboard functions and fixed constant usage |
| pkg/console/handler/*.go | Refactored dashboard handlers to use new configuration structure |
| pkg/console/model/*.go | Updated model structures for observability requests |
| pkg/config/**/*.go | Restructured configuration with new observability and log configs, added validation |
| app/dubbo-ui/dist/admin/* | Updated UI dist files (binary/generated content) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
release/kubernetes/dubbo-samples-shop/dubbo-samples-shop-all.yaml
Outdated
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 20 out of 250 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 participant
Please provide a description of this PR:
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.
Please check any characteristics that apply to this pull request.