Skip to content

fix(toolbox): fix updateView and dispose silently no-oping on toolbox features #21684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mzabuawala wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −2
Open

fix(toolbox): fix updateView and dispose silently no-oping on toolbox features #21684

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/component/toolbox/ToolboxView.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,9 @@ class ToolboxView extends ComponentView {
api: ExtensionAPI,
payload: unknown
) {
each(this._features, function (feature) {
// `_features` is a `HashMap` rather than a plain object, so it has to be
// iterated with its own `each` method - `zrUtil.each` cannot traverse it.
this._features && this._features.each(function (feature) {
feature
&& feature instanceof ToolboxFeature
&& feature.updateView
Expand All @@ -386,7 +388,7 @@ class ToolboxView extends ComponentView {
}

dispose(ecModel: GlobalModel, api: ExtensionAPI) {
each(this._features, function (feature) {
this._features && this._features.each(function (feature) {
feature
&& feature instanceof ToolboxFeature
&& feature.dispose
Expand Down