fix(sunburst): preserve data decal. close #18118#21687
Open
rahul37wallst-sudo wants to merge 1 commit into
Open
fix(sunburst): preserve data decal. close #18118#21687rahul37wallst-sudo wants to merge 1 commit into
rahul37wallst-sudo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Preserve sunburst data item decal overrides when ARIA decal generation is enabled.
Fixed issues
series-sunburst.data.itemStyle.decalwas overwritten byaria.decal.decals.Details
Before: What was the problem?
When
aria.decal.showwas enabled for a sunburst series, the tree-specific ARIA decal helper assigned palette decals directly to each tree node.Because sunburst ignores generic data item style processing,
series.data[].itemStyle.decalwas not preserved before ARIA decal assignment. As a result, a data item such as:still rendered with the global ARIA decal, for example
symbol: 'circle'.After: How does it behave after the fixing?
The tree ARIA decal helper now reads a node's
itemStyle.decal, merges it over the palette decal, and preserves explicitdecal: 'none'.This allows sunburst data items to override or disable the ARIA decal while keeping palette decals for items without an override.
A regression test was added for the sunburst + ARIA decal case.
Document Info
One of the following should be checked.
Misc
Security Checking
ZRender Changes
Related test cases or examples to use the new APIs
test/ut/spec/series/sunburst.test.tsMerging options
Other information
Validation run locally: