Skip to content

FINERACT-2399: Add global config to block transactions on closed/overpaid loans #5349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
airajena wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

FINERACT-2399: Add global config to block transactions on closed/overpaid loans #5349

airajena wants to merge 1 commit into from

Conversation

@airajena
Copy link
Contributor

@airajena airajena commented Jan 19, 2026

Description

Fixes FINERACT-2399

This PR adds a new global configuration block-transactions-on-closed-overpaid-loans that allows organizations to prevent monetary transactions on loan accounts with closed or overpaid status.

Problem

Currently, Fineract allows monetary transactions (repayments, refunds, charges, etc.) on loans that are in closed or overpaid status. This can cause:

  • Data integrity issues
  • Accounting reconciliation problems
  • Unintended transactions on settled accounts

Solution

Added a global configuration toggle:

  • When disabled (default): Current behavior preserved - transactions allowed on closed/overpaid loans
  • When enabled: Monetary transactions are blocked with appropriate error message

@adamsaghy
Copy link
Contributor

adamsaghy commented Jan 20, 2026

Please dont forget to run ./gradlew spotlessApply spotbugsMain spotbugsTest checkstyleMain checkstyleTest before ALL commits!

@airajena airajena force-pushed the FINERACT-2399/block-transactions-closed-overpaid-loans branch from 00f29ec to 7a00cba Compare January 21, 2026 18:46
@adamsaghy
Copy link
Contributor

adamsaghy commented Jan 23, 2026 •
edited
Loading

Please dont forget to run ./gradlew spotlessApply spotbugsMain spotbugsTest checkstyleMain checkstyleTest before ALL commits!

@airajena
Copy link
Contributor Author

airajena commented Jan 23, 2026

Please dont forget to run ./gradlew spotlessApply spotbugsMain spotbugsTest checkstyleMain checkstyleTest before ALL commits!

Thanks for the reminder! Just a quick clarification: Is it sufficient to run these checks specifically on the modules I've modified (e.g., ./gradlew :integration-tests:spotlessApply ...), or do you require them to be run on the entire project root? Running them on the root seems to trigger issues in unrelated modules.

@adamsaghy
Copy link
Contributor

adamsaghy commented Jan 23, 2026

Please dont forget to run ./gradlew spotlessApply spotbugsMain spotbugsTest checkstyleMain checkstyleTest before ALL commits!

Thanks for the reminder! Just a quick clarification: Is it sufficient to run these checks specifically on the modules I've modified (e.g., ./gradlew :integration-tests:spotlessApply ...), or do you require them to be run on the entire project root? Running them on the root seems to trigger issues in unrelated modules.

Its just easier to run this as i shared and fix all places ;)

@airajena airajena force-pushed the FINERACT-2399/block-transactions-closed-overpaid-loans branch from 7a00cba to b28f4e5 Compare January 24, 2026 06:33
adamsaghy
adamsaghy requested changes Jan 26, 2026
View reviewed changes
Copy link
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Credit Balance Refund txn cannot be blocked! That is for handle overpaid status correctly!

adamsaghy
adamsaghy reviewed Jan 26, 2026
View reviewed changes
...hangelog/tenant/parts/0208_add_configuration_block_transactions_on_closed_overpaid_loans.xml Outdated
Comment on lines 26 to 28
<sql>
SELECT SETVAL('c_configuration_id_seq', COALESCE(MAX(id), 0)+1, false ) FROM c_configuration;
</sql>
Copy link
Contributor

@adamsaghy adamsaghy Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think we need this. Are you sure this should be here?

adamsaghy
adamsaghy requested changes Jan 26, 2026
View reviewed changes
Copy link
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add proper testing to ensure correct behavior!

@airajena airajena force-pushed the FINERACT-2399/block-transactions-closed-overpaid-loans branch 2 times, most recently from ebb2fc9 to eac6fa3 Compare February 3, 2026 06:48
@airajena
Copy link
Contributor Author

airajena commented Feb 3, 2026

Please add proper testing to ensure correct behavior!

Done

@airajena airajena force-pushed the FINERACT-2399/block-transactions-closed-overpaid-loans branch 7 times, most recently from 7c54556 to 28ca56a Compare February 9, 2026 20:05
@airajena airajena force-pushed the FINERACT-2399/block-transactions-closed-overpaid-loans branch from 28ca56a to fb8055a Compare February 10, 2026 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamsaghy adamsaghy adamsaghy requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@airajena @adamsaghy