Skip to content

Conversation

@vidakovic
Copy link
Contributor

Description

Major improvement of document management. Non of the core structures are located outside of "fineract-document" (almost standalone). Major performance improvement due to true streaming of documents (no byte array loading into memory... unless we deal with base64 encoded data). Content is now streamed asynchronously. Document management was actually not using the command concept at all. All document and image operations were not showing up in any audit logs. Everything is now migrated to the new command processing. Applied a technique to remove direct dependencies to staff and client packages.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@vidakovic vidakovic self-assigned this Feb 8, 2026
@vidakovic vidakovic force-pushed the feature/FINERACT-2246 branch 8 times, most recently from d14baf0 to 692ae26 Compare February 9, 2026 12:09
@vidakovic vidakovic requested a review from galovics February 9, 2026 12:25
@vidakovic vidakovic force-pushed the feature/FINERACT-2246 branch from 692ae26 to 298b15e Compare February 9, 2026 13:27
@vidakovic vidakovic requested a review from adamsaghy February 9, 2026 13:28
@vidakovic vidakovic force-pushed the feature/FINERACT-2246 branch 7 times, most recently from 163d54b to 06b2e41 Compare February 10, 2026 22:27
@vidakovic vidakovic requested a review from IOhacker February 10, 2026 22:42
@vidakovic vidakovic force-pushed the feature/FINERACT-2246 branch 2 times, most recently from 35a3f70 to 23f2f9b Compare February 10, 2026 23:11
@IOhacker
Copy link
Contributor

@vidakovic seems that there are some conflicts

@vidakovic
Copy link
Contributor Author

It's actually only one thing left: the bulk import test cases try to retrieve the uploaded documents from the local file system... Which is different when you run your tests locally, in a docker Container or on GitHub actions

@vidakovic vidakovic force-pushed the feature/FINERACT-2246 branch 6 times, most recently from 7c78e18 to 7e9c787 Compare February 12, 2026 11:10
@vidakovic vidakovic force-pushed the feature/FINERACT-2246 branch 2 times, most recently from 0930ce9 to 68b30cc Compare February 12, 2026 13:40
@vidakovic vidakovic force-pushed the feature/FINERACT-2246 branch from 68b30cc to d684b27 Compare February 13, 2026 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants