FINERACT-2421: Fix Progressive Loan - Missing Model Issues #5472
+193
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somasorosdpc
force-pushed
the
FINERACT-2421/fix-missing-progressive-model
branch
5 times, most recently
from
bb818b3 to
69fc174
Compare
somasorosdpc
force-pushed
the
FINERACT-2421/fix-missing-progressive-model
branch
2 times, most recently
from
6c6a32d to
1167af4
Compare
adamsaghy
reviewed
Feb 12, 2026
| case NONE -> throw new IllegalStateException("Unexpected PreClosureInterestCalculationStrategy: NONE"); | ||
| }; | ||
|
|
||
| // TODO: usually used for read operations, if model is incorrect (changed state), we need to wait till something |
adamsaghy
reviewed
Feb 12, 2026
| extends JpaSpecificationExecutor<ProgressiveLoanModel>, JpaRepository<ProgressiveLoanModel, Long> { | ||
|
|
||
| Optional<ProgressiveLoanModel> findOneByLoanId(Long loanId); | ||
| Optional<ProgressiveLoanModel> findOneByLoanId(Long loan_id); |
adamsaghy
reviewed
Feb 12, 2026
|
|
||
| @Override | ||
| public Long removeByLoanId(Long loanId) { | ||
| return loanModelRepository.removeByLoan_Id(loanId); |
Contributor
There was a problem hiding this comment.
Please avoid using snake case method names
adamsaghy
reviewed
Feb 12, 2026
|
|
||
| private ChangedTransactionDetail processLatestTransactionProgressiveInterestRecalculation( | ||
| AdvancedPaymentScheduleTransactionProcessor advancedProcessor, Loan loan, LoanTransaction loanTransaction) { | ||
| // TODO: Lets recalculate the model if it is incorrect, it is used by WRITE operations |
adamsaghy
reviewed
Feb 12, 2026
|
|
||
| TransactionCtx transactionCtx; | ||
| if (transactionProcessor instanceof AdvancedPaymentScheduleTransactionProcessor) { | ||
| // Fixed: prevented to use it without a model. shouldReprocessLoan used for it. |
adamsaghy
reviewed
Feb 12, 2026
| @Override | ||
| public void updateModel(Loan loan) { | ||
| // recalculate the model if it is incorrect, it is used by WRITE operations | ||
| // Fixed on caller side |
somasorosdpc
force-pushed
the
FINERACT-2421/fix-missing-progressive-model
branch
from
1167af4 to
a56c07a
Compare
… Runs * COB Periodic Accruals Create model if model is not saved before calculate new accrual * Force Reprocess All Transactions in case there is no Saved Model * Create Internal API Endpoint and LoanStepDef to remove ProgressiveLoanInterestScheduleModel by loanId
somasorosdpc
force-pushed
the
FINERACT-2421/fix-missing-progressive-model
branch
from
a56c07a to
4a102e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COB runs can fail for Progressive Loans if there are no entry for Saved Progressive Model in DB.