FINERACT-2488: Fix duplicate results in /api/v2/clients/search#5485
Open
rhopman wants to merge 1 commit intoapache:developfrom
Open
FINERACT-2488: Fix duplicate results in /api/v2/clients/search#5485rhopman wants to merge 1 commit intoapache:developfrom
rhopman wants to merge 1 commit intoapache:developfrom
Conversation
Contributor
Author
|
I see that the Verify Liquibase Backward Compatibility check failed. I ran it locally, and on my machine it passes (i.e. the service comes up and the health endpoint reports "UP"). I also cannot think of any reason why the change in this PR would cause this check to break. The error does not seem to be related to the change, as far as I can tell. Can anyone offer some advice here? Is this check usually reliable? |
f08f599 to
96926b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
/api/v2/clients/searchendpoint returns duplicate entries when a client has multiple identifiers matching the search criteria. When searching by identifier document key, clients with multiple matching identifiers appear multiple times in the result set.Checklist
Your assigned reviewer(s) will follow our guidelines for code reviews.