This repository was archived by the owner on Feb 19, 2025. It is now read-only.
[WIP] OpenTelemetry Web Request Tracing#388
Draft
EandrewJones wants to merge 1 commit intoapache:masterfrom
Draft
[WIP] OpenTelemetry Web Request Tracing#388EandrewJones wants to merge 1 commit intoapache:masterfrom
EandrewJones wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
I'm going to dig into this, but first here's some notes on working in this repo:
|
Contributor
Author
|
Apologies for breach of convention.
Can do. I believe my VS code is auto-formatting on save so I'll have to
parse that out.
Best
Evan Jones
Website: www.ea-jones.com
…On Mon, Nov 6, 2023 at 1:50 PM Jason Young ***@***.***> wrote:
I'm going to dig into this, but first here's some notes on working in this
repo:
- Include the build in your branch.
- Make PR's to test.
- For QOL, can you separate the formatting changes and the code
changes into different commits?
—
Reply to this email directly, view it on GitHub
<#388 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJ2T6AIGQ7FNFZNS6KTJ5QDYDEWPZAVCNFSM6AAAAAA676C7CSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJVHEZDIOJSHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Contributor
|
After working on this with Evan, we couldn't get a successful build. The opentelemetry package requires perf hooks, but we couldn't find any polyfill in the rollup ecosystem that supports it. We concluded that adding otel would require migrating to a different bundler. We instead updated an example webpack site that injects otel info into userale logs. Check it out here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
Instructions
npm installnpm run pretestto see build warnings/errors.