Code changes for toolName and toolVersion constraints#411
Code changes for toolName and toolVersion constraints#411r2o3k wants to merge 4 commits intoapache:testfrom
Conversation
EandrewJones
left a comment
EandrewJones
left a comment
There was a problem hiding this comment.
Make these minor changes and then we need to have tests pass.
Beleive @Jyyjy has to trigger tests. (note to self we really need to get automated checks in place)
Any committer can trigger tests, and they will automatically trigger if a committer makes a PR. Of course you also have to link your Apache id to your GitHub account |
I'm not yet a committer. I submitted my paperwork but still awaiting things like apache id. |
| settings.logCountThreshold = +get('data-threshold') || 5; | ||
| settings.userId = get('data-user') || null; | ||
| settings.version = get('data-version') || null; | ||
| settings.toolVersion = get('data-version') || null; |
There was a problem hiding this comment.
this is where I was referencing changing the script tag to match the setting name.
so it'd be:
get('data-tool-version')
This is a breaking change, because it changes the script-tag api. And since toolVersion is required, the script would throw if users did not set this field.
We should add a default besides null to keep it from breaking (e.g. '1.0').
3 participants
No description provided.