[FLINK-AGENTS][api] Add ResourceName constants for AWS integrations#679
Merged
Merged
Conversation
The Bedrock chat / Bedrock embedding (PR apache#534) and OpenSearch / S3 Vectors (PR apache#533) integrations were merged without ResourceName constants. Users currently have to reference these implementations via fully-qualified class name strings, e.g. BedrockChatModelConnection.class.getName() while every other built-in provider gets a constant under ResourceName, e.g. ResourceName.ChatModel.OLLAMA_CONNECTION Add the missing constants so AWS integrations match the established pattern, both for Java agents: ResourceName.ChatModel.BEDROCK_CONNECTION / BEDROCK_SETUP ResourceName.EmbeddingModel.BEDROCK_CONNECTION / BEDROCK_SETUP ResourceName.VectorStore.OPENSEARCH_VECTOR_STORE ResourceName.VectorStore.S3_VECTORS_VECTOR_STORE and Python agents using these via the cross-language wrapper: ResourceName.ChatModel.Java.BEDROCK_CONNECTION / BEDROCK_SETUP ResourceName.EmbeddingModel.Java.BEDROCK_CONNECTION / BEDROCK_SETUP ResourceName.VectorStore.Java.OPENSEARCH_VECTOR_STORE ResourceName.VectorStore.Java.S3_VECTORS_VECTOR_STORE This is purely additive; existing code that references the FQCN string continues to work unchanged.
github-actions
Bot
added
doc-label-missing
wenjin272
added
doc-not-needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #675
Adds the missing constants so AWS integrations match every other built-in provider:
Plus matching Python-side entries for cross-language usage.