[ci] Replace burnett01/rsync-deployments with local composite action#703
Merged
Conversation
Add a local composite action under .github/actions/rsync-deployments that wraps rsync-over-SSH for documentation deployment. Ported from apache/flink-kubernetes-operator#1035 with MIT attribution preserved. This action is intended to replace the third-party burnett01/rsync-deployments action, which is not in the ASF allowed-actions list. Locally-defined actions are not subject to that allow-list, so they can be used safely in ASF repositories. This commit is purely additive (no existing files modified) and can be cherry-picked cleanly to release branches so the nightly docs matrix job can resolve the local action when checking out those branches.
Switch the two upload steps in .github/workflows/docs.yml from burnett01/rsync-deployments to the locally-defined action added in the previous commit. This fixes the nightly docs build, which currently fails because the third-party action is not in the ASF allowed-actions list. This commit only touches main's workflow file. The cron trigger always reads the workflow definition from the default branch, so release branches do not need this change for the scheduled build to work -- they only need the local action committed alongside.
github-actions
Bot
added
doc-not-needed
Collaborator
Author
|
Hi, @xintongsong. Could you please review this PR? Thank you! |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of change
The nightly
Build Documentationworkflow fails becauseburnett01/rsync-deploymentsis not in the ASF allowed-actions list. Replace it with a local composite action under.github/actions/rsync-deployments/, ported from apache/flink-kubernetes-operator#1035.🔔 Note for committer
Please cherry-pick the first commit only (
Add local rsync-deployments composite action) ontorelease-0.1andrelease-0.2. The matrix job checks those branches out and resolves the local action from the workspace, so the action file must exist on each branch. The second commit (workflow change) is only needed onmain— cron always reads the workflow from the default branch.Tests
Verified on a personal fork: the local action loads and runs. It fails at
ssh-addwitherror in libcryptobecause theNIGHTLIES_RSYNC_KEYsecret only exists inapache/flink-agents. Full verification needs aworkflow_dispatchon the Apache repo after merge.API
No
Documentation
doc-neededdoc-not-neededdoc-included