[FLINK-30514] Fix HybridSourceReader's method calling order for underlying subsources during source switch#28069
Open
shanzi wants to merge 2 commits intoapache:masterfrom
Open
[FLINK-30514] Fix HybridSourceReader's method calling order for underlying subsources during source switch#28069shanzi wants to merge 2 commits intoapache:masterfrom
shanzi wants to merge 2 commits intoapache:masterfrom
Conversation
Collaborator
…r switch methods order
Author
|
@flinkbot run connector-base |
Author
|
cc @tweise @WencongLiu @xccui Can you have a look given you contributed to this file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This MR is intended to fix the method calling order of the HybridSourceReader described in FLINK-30514. We found it not only affects the File connector but also the Iceberg connector.
In our usage, we'd like to use Iceberg Connector as the first source of the HybridSource, however, we found due to the HybridSource is calling
startbeforeaddSplits(which will be called during recovery), it breaks IcebergSourceSplitReader's assumption: the recovered splits will be added beforestart.In the
startmethod, the IcebergSourceSplitReader with check if there is recovered splits on start, and decide if to request new splits. The wrong order in the HybridSource will lead to a undesired requests of new splits, which breaks watermark, slows down the reading and endangers the stability of a job.Brief change log
start()after the recovered splits were added to the reader first.Verifying this change
Unit tests was updated to verify the behavior.
Does this pull request potentially affect one of the following parts:
Documentation