[FLINK-36779][table] Fix metric is incorrect and non-changing during the time in Rank#28118
Open
Au-Miner wants to merge 1 commit intoapache:masterfrom
Open
[FLINK-36779][table] Fix metric is incorrect and non-changing during the time in Rank#28118Au-Miner wants to merge 1 commit intoapache:masterfrom
Au-Miner wants to merge 1 commit intoapache:masterfrom
Conversation
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fix the
topn.cache.sizeandtopn.cache.hitRatemetrics in TopN operators, which were frozen at their initial values and never reflected the live cache state.Brief change log
AbstractTopNFunction#registerMetricto acceptLongSupplierinstead oflong, so the registeredGaugelambdas read the current values on every poll instead of capturing a snapshot at registration time.AppendOnlyTopNHelper,FastTop1HelperandUpdatableTopNFunctioncall sites to pass suppliers.Verifying this change
Added a shared helper
testCacheMetricsReflectLiveStateinTopNFunctionTestBaseand overrides inAppendOnlyTopNFunctionTest,FastTop1FunctionTestandUpdatableTopNFunctionTestthat assert thetopn.cache.sizegauge increases after records are processed.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
找到具有 1 个许可证类型的类似代码