Skip to content

[FLINK-39788][kubernetes] Append .svc suffix to namespaced Kubernetes service hostnames #28493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wilmerdooley wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[FLINK-39788][kubernetes] Append .svc suffix to namespaced Kubernetes service hostnames #28493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...main/java/org/apache/flink/kubernetes/kubeclient/decorators/ExternalServiceDecorator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,6 @@ public static String getExternalServiceName(String clusterId) {
* project, so do not delete it.
*/
public static String getNamespacedExternalServiceName(String clusterId, String namespace) {
return getExternalServiceName(clusterId) + "." + namespace;
return getExternalServiceName(clusterId) + "." + namespace + ".svc";
}
}
2 changes: 1 addition & 1 deletion ...main/java/org/apache/flink/kubernetes/kubeclient/decorators/InternalServiceDecorator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,6 @@ public static String getInternalServiceName(String clusterId) {

/** Generate namespaced name of the internal Service. */
public static String getNamespacedInternalServiceName(String clusterId, String namespace) {
return getInternalServiceName(clusterId) + "." + namespace;
return getInternalServiceName(clusterId) + "." + namespace + ".svc";
}
}
2 changes: 1 addition & 1 deletion flink-kubernetes/src/main/java/org/apache/flink/kubernetes/utils/KubernetesUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -691,7 +691,7 @@ public static String extractLeaderName(String key) {

/** Generate namespaced name of the service. */
public static String getNamespacedServiceName(Service service) {
return service.getMetadata().getName() + "." + service.getMetadata().getNamespace();
return service.getMetadata().getName() + "." + service.getMetadata().getNamespace() + ".svc";
}

private KubernetesUtils() {}
Expand Down
3 changes: 2 additions & 1 deletion ...kubernetes/src/test/java/org/apache/flink/kubernetes/KubernetesClusterDescriptorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,8 @@ void testDeployApplicationClusterWithClusterIP() throws Exception {
.deployApplicationCluster(clusterSpecification, appConfig)
.getClusterClient();

final String address = CLUSTER_ID + Constants.FLINK_REST_SERVICE_SUFFIX + "." + NAMESPACE;
final String address =
CLUSTER_ID + Constants.FLINK_REST_SERVICE_SUFFIX + "." + NAMESPACE + ".svc";
final int port = flinkConfig.get(RestOptions.PORT);
assertThat(clusterClient.getWebInterfaceURL())
.isEqualTo(String.format("http://%s:%d", address, port));
Expand Down