[FLINK-39966][table-planner] FlinkRelMdModifiedMonotonicity wrongly reports a non-time-attribute Top-1 Rank as insert-only#28505
Merged
Conversation
…eports a non-time-attribute Top-1 Rank as insert-only FLINK-34702 removed the dedicated StreamPhysicalDeduplicate metadata handler and re-routed deduplication monotonicity through StreamPhysicalRank, but the new dispatch guard only checked RankUtil.isDeduplication (Top-1 ROW_NUMBER without rank number). It dropped the sortOnTimeAttributeOnly invariant the old node type implicitly carried. Tighten the guard to isDeduplication && sortOnTimeAttributeOnly restoring the original logic.
Collaborator
lincoln-lil
added a commit
to lincoln-lil/flink
that referenced
this pull request
Jun 23, 2026
…eports a non-time-attribute Top-1 Rank as insert-only FLINK-34702 removed the dedicated StreamPhysicalDeduplicate metadata handler and re-routed deduplication monotonicity through StreamPhysicalRank, but the new dispatch guard only checked RankUtil.isDeduplication (Top-1 ROW_NUMBER without rank number). It dropped the sortOnTimeAttributeOnly invariant the old node type implicitly carried. Tighten the guard to isDeduplication && sortOnTimeAttributeOnly restoring the original logic. This closes apache#28505.
lincoln-lil
added a commit
to lincoln-lil/flink
that referenced
this pull request
Jun 23, 2026
…rongly reports a non-time-attribute Top-1 Rank as insert-only FLINK-34702 removed the dedicated StreamPhysicalDeduplicate metadata handler and re-routed deduplication monotonicity through StreamPhysicalRank, but the new dispatch guard only checked RankUtil.isDeduplication (Top-1 ROW_NUMBER without rank number). It dropped the sortOnTimeAttributeOnly invariant the old node type implicitly carried. Tighten the guard to isDeduplication && sortOnTimeAttributeOnly restoring the original logic. This closes apache#28505.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
FLINK-34702 removed the dedicated StreamPhysicalDeduplicate metadata handler and re-routed deduplication monotonicity through StreamPhysicalRank, but the new dispatch guard only checked RankUtil.isDeduplication (Top-1 ROW_NUMBER without rank number). It dropped the sortOnTimeAttributeOnly invariant the old node type implicitly carried.
Brief change log
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving): ( no)Documentation