[VL] Enable hour(timestamp_ntz) native execution in Velox backend#12064
[VL] Enable hour(timestamp_ntz) native execution in Velox backend#12064Mariamalmesfer wants to merge 3 commits into
Conversation
|
Run Gluten Clickhouse CI on x86 |
Mariamalmesfer
force-pushed
the
ts-ntz-hour-support
branch
from
a6f6da4 to
1caa32d
Compare
|
Run Gluten Clickhouse CI on x86 |
|
@Mariamalmesfer The failed tests seem to be related. Would you please take a look? |
Mariamalmesfer
force-pushed
the
ts-ntz-hour-support
branch
from
1caa32d to
6eb56a9
Compare
|
Run Gluten Clickhouse CI on x86 |
Mariamalmesfer
force-pushed
the
ts-ntz-hour-support
branch
from
6eb56a9 to
2ca0457
Compare
|
Run Gluten Clickhouse CI on x86 |
Mariamalmesfer
force-pushed
the
ts-ntz-hour-support
branch
from
2ca0457 to
9a8604b
Compare
|
Run Gluten Clickhouse CI on x86 |
Mariamalmesfer
force-pushed
the
ts-ntz-hour-support
branch
from
9a8604b to
e893155
Compare
|
Run Gluten Clickhouse CI on x86 |
Mariamalmesfer
force-pushed
the
ts-ntz-hour-support
branch
from
e893155 to
516ee09
Compare
|
Run Gluten Clickhouse CI on x86 |
Mariamalmesfer
force-pushed
the
ts-ntz-hour-support
branch
from
516ee09 to
4a9d538
Compare
|
Run Gluten Clickhouse CI on x86 |
|
This PR depends on facebookincubator/velox#17557, which registers hour(TIMESTAMP UTC) in Velox. The CI failure is expected once that Velox PR merges and Gluten updates its pinned Velox version, this PR will be ready. |
Mariamalmesfer
force-pushed
the
ts-ntz-hour-support
branch
from
4a9d538 to
9b8a205
Compare
|
Run Gluten Clickhouse CI on x86 |
rui-mo
left a comment
rui-mo
left a comment
There was a problem hiding this comment.
Hi @Mariamalmesfer, you can point this PR to your Velox PR by updating https://github.com/apache/gluten/blob/main/ep/build-velox/src/get-velox.sh#L28 with your PR number. This will allow us to run and verify the Gluten tests against your changes.
Mariamalmesfer
force-pushed
the
ts-ntz-hour-support
branch
from
9b8a205 to
7422824
Compare
|
Run Gluten Clickhouse CI on x86 |
Mariamalmesfer
force-pushed
the
ts-ntz-hour-support
branch
from
7422824 to
626d5a2
Compare
|
Run Gluten Clickhouse CI on x86 |
Mariamalmesfer
force-pushed
the
ts-ntz-hour-support
branch
from
626d5a2 to
f083737
Compare
|
Run Gluten Clickhouse CI on x86 |
Mariamalmesfer
force-pushed
the
ts-ntz-hour-support
branch
from
9fbd231 to
6eff3a9
Compare
|
Run Gluten Clickhouse CI on x86 |
Mariamalmesfer
force-pushed
the
ts-ntz-hour-support
branch
from
6eff3a9 to
e1e6e7b
Compare
|
Run Gluten Clickhouse CI on x86 |
rui-mo
force-pushed
the
ts_ntz_dev
branch
2 times, most recently
from
d5bbbf7 to
63fc54b
Compare
Mariamalmesfer
force-pushed
the
ts-ntz-hour-support
branch
from
e1e6e7b to
86e02fd
Compare
|
Run Gluten Clickhouse CI on x86 |
Mariamalmesfer
force-pushed
the
ts-ntz-hour-support
branch
from
86e02fd to
c6753f8
Compare
|
Run Gluten Clickhouse CI on x86 |
Mariamalmesfer
force-pushed
the
ts-ntz-hour-support
branch
from
c6753f8 to
51bef6b
Compare
|
Run Gluten Clickhouse CI on x86 |
|
@rui-mo the Velox PR facebookincubator/velox#17557 has been merged. This Gluten PR is now ready for review |
zhouyuan
changed the title
Mariamalmesfer
force-pushed
the
ts-ntz-hour-support
branch
from
51bef6b to
bb16649
Compare
|
Run Gluten Clickhouse CI on x86 |
rui-mo
force-pushed
the
ts_ntz_dev
branch
2 times, most recently
from
df10cf0 to
5afbafd
Compare
|
Thanks, @Mariamalmesfer. I'll try to get PR #12229 merged this week. Once it's landed, you can open your PR directly against the main branch. |
rui-mo
force-pushed
the
ts_ntz_dev
branch
3 times, most recently
from
22a7b49 to
793140b
Compare
3 participants
Enable hour(timestamp_ntz) to run natively in the Velox backend instead of falling back to Spark.