[CORE] Optimize Iceberg schema field matching#12233
Open
wankunde wants to merge 1 commit into
Open
Conversation
|
Run Gluten Clickhouse CI on x86 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Why this PR is needed?
In
IcebergScanTransformer.typesMatch(), the struct type matching logic creates temporary IcebergSchemaobjects for every Spark field:This repeatedly rebuilds Iceberg schema indexes while checking historical schemas, which can become expensive for wide schemas or tables with many schema versions. In production thread dumps, this shows up in

Schema/IndexByName/HashMapinitialization during Iceberg scan planning.Changes in this PR:
This change uses
Types.StructType.field(name)andTypes.StructType.field(id)directly when matching nested struct fields.Types.StructTypealready provides field lookup by name and id, so this avoids constructing temporarySchemaobjects inside the field loop while preserving the existing matching behavior:How was this patch tested?
Test with exist UT
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Codex GPT-5