[GLUTEN-12249][FLINK] Fix(gluten-flink/planner): use getValueAs() to extract VARCHAR literal value#12250
Open
ggjh-159 wants to merge 1 commit into
Open
[GLUTEN-12249][FLINK] Fix(gluten-flink/planner): use getValueAs() to extract VARCHAR literal value#12250ggjh-159 wants to merge 1 commit into
ggjh-159 wants to merge 1 commit into
Conversation
ggjh-159
force-pushed
the
fix_varchar_nlsstring_prefix
branch
2 times, most recently
from
04574ff to
53dd14c
Compare
Author
|
@philo-he @lgbo-ustc @zhanglistar @KevinyhZou Would you mind reviewing this PR？ |
ggjh-159
force-pushed
the
fix_varchar_nlsstring_prefix
branch
3 times, most recently
from
9ac6052 to
0939f47
Compare
Use getValueAs(String.class) instead of getValue().toString() which produces "_UTF-16LE'value'" from NlsString.
ggjh-159
force-pushed
the
fix_varchar_nlsstring_prefix
branch
from
0939f47 to
100bd35
Compare
KevinyhZou
approved these changes
Jun 10, 2026
KevinyhZou
left a comment
KevinyhZou
left a comment
Contributor
There was a problem hiding this comment.
This problem also seems to exist in toVariant(Comparable ....) Of RexNodeConverter, can be fixed in another pr. LGTM
Author
May be this pr? #12267 |
Contributor
|
yes, fix it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Use getValueAs(String.class) to get the plain value, consistent with the CHAR branch.
Related issue: #12249
How was this patch tested?
Manual test. Verified with nexmark q14 on Velox-Flink (10000 events, 2533 output rows):
_UTF-16LE'nightTime'or_UTF-16LE'otherTime'nightTime), matching native Flink outputWas this patch authored or co-authored using generative AI tooling?