-
-
Notifications
You must be signed in to change notification settings - Fork 968
docs: update RELEASE.md examples for 8.0.0-M1 #15619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jamesfredley
wants to merge
1
commit into
8.0.x
Choose a base branch
from
docs/release-md-update-for-8.0.0-m1
base: 8.0.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+8
−8
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,8 +34,8 @@ During the staging step, we must create a source distribution & stage any binary | |
| 1. Create a release in `grails-core`: | ||
| * Click "Draft a new release" here: https://github.com/apache/grails-core/releases | ||
| * On the draft new release screen, we execute the following steps: | ||
| * The tag will have the prefix 'v', so for our release it would be 'v7.0.0-M4' | ||
| * The "Target" will be the branch we build out of (this case it's the default, 7.0.x) | ||
| * The tag will have the prefix 'v', so for our release it would be 'v8.0.0-M1' | ||
| * The "Target" will be the branch we build out of (in this case, 8.0.x) | ||
| * Previous tag will be auto | ||
| * Click "Generate Release Notes" | ||
| * This will then scan our commit history and we adjust the release notes per project agreement. | ||
|
|
@@ -77,7 +77,7 @@ Prior to releasing a vote, we need to verify the staged artifacts. The below sec | |
|
|
||
| For Example: | ||
| ```bash | ||
| verify.sh v7.0.0-M4 /tmp/grails-verify | ||
| verify.sh v8.0.0-M1 /tmp/grails-verify | ||
| ``` | ||
|
|
||
| Please note that this script will perform steps that will require rebuilding the project & comparing the built artifacts | ||
|
|
@@ -132,13 +132,13 @@ To ensure checksums match the server & signatures match, run the script `etc/bin | |
|
|
||
| Example: | ||
| ```bash | ||
| ./etc/bin/verify-jar-artifacts.sh v7.0.0-M4 <grailsdownloadlocation> | ||
| ./etc/bin/verify-jar-artifacts.sh v8.0.0-M1 <grailsdownloadlocation> | ||
| ``` | ||
|
|
||
| ### Manual Verification: Reproducible Jar Files | ||
| After all jar files are verified to be signed by a valid Grails key, we need to build a local copy to ensure the file was built with the right code base. The `very-reproducible.sh` script handles this check, but if the bootstrap needs to be manually bootstrapped, perform the following step: | ||
| After all jar files are verified to be signed by a valid Grails key, we need to build a local copy to ensure the file was built with the right code base. The `verify-reproducible.sh` script handles this check, but if the bootstrap needs to be manually bootstrapped, perform the following step from inside the downloaded source distribution: | ||
|
|
||
| gradle -p gradle-bootstrap | ||
| cd gradle-bootstrap && gradle | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why are you changing this? |
||
|
|
||
| Further details on the building can be found in the [INSTALL](INSTALL) document. Otherwise, run the `verify-reproducible.sh` shell script to compare the published jar files to a locally built version of them. | ||
|
|
||
|
|
@@ -288,7 +288,7 @@ an example call to the checked in script to move the distributions. | |
| After moving the distributions, you will receive an email from the ASF reporter. Click the link in the email to mark the | ||
| release as published or go to https://reporter.apache.org/addrelease.html?grails. The `release` job in the `Release` workflow has a step to remind you of this. | ||
|
|
||
| For example, if the release is out of core with version `7.0.0-M4`, then the release name with be `CORE-7.0.0-M4`. Enter | ||
| For example, if the release is out of core with version `8.0.0-M1`, then the release name will be `CORE-8.0.0-M1`. Enter | ||
| the date you moved the distribution artifacts and report the release. | ||
|
|
||
| ### Deploy the release to Grails Forge | ||
|
|
@@ -383,7 +383,7 @@ Setup the key for validity: | |
| # Appendix: Verification from a Container | ||
|
|
||
| The Grails image is officially built on linux in a GitHub action using an Ubuntu container. To run a linux container | ||
| locally, you can use the following command (substitute `<git-tag-of-release` with the tag name): | ||
| locally, you can use the following command (substitute `<git-tag-of-release>` with the tag name, e.g. `v8.0.0-M1`): | ||
|
|
||
| **macOS/Linux** | ||
| ```bash | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why even bother changing this? The point of this is to just give an example release tag, not keep
it in sync with our version