-
-
Notifications
You must be signed in to change notification settings - Fork 968
fix: enforce LF line endings for shell scripts, gradlew, KEYS #15620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+62
−0
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one or more | ||
| # contributor license agreements. See the NOTICE file distributed with | ||
| # this work for additional information regarding copyright ownership. | ||
| # The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| # (the "License"); you may not use this file except in compliance with | ||
| # the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| # Git auto-detects text vs binary; text files are stored as LF in the index. | ||
| * text=auto | ||
|
|
||
| # Files that MUST be LF on every platform. | ||
| # Shell scripts, the Gradle wrapper launcher, the published KEYS file, and the | ||
| # Dockerfile all run on Linux during release verification. CRLF in any of them | ||
| # breaks the verification flow (kernel rejects scripts with bash\r shebangs and | ||
| # verify-keys.sh fails the byte-for-byte SVN comparison). | ||
| *.sh text eol=lf | ||
| gradlew text eol=lf | ||
| KEYS text eol=lf | ||
| Dockerfile text eol=lf | ||
| *.properties text eol=lf | ||
|
|
||
| # Files that MUST be CRLF (Windows scripts). | ||
| *.bat text eol=crlf | ||
| *.cmd text eol=crlf | ||
| gradlew.bat text eol=crlf | ||
|
|
||
| # Common binary types - never normalize. | ||
| *.jar binary | ||
| *.zip binary | ||
| *.gz binary | ||
| *.tgz binary | ||
| *.7z binary | ||
| *.png binary | ||
| *.jpg binary | ||
| *.jpeg binary | ||
| *.gif binary | ||
| *.ico binary | ||
| *.pdf binary | ||
| *.p12 binary | ||
| *.gpg binary | ||
| *.keystore binary | ||
| *.class binary | ||
| *.so binary | ||
| *.dylib binary | ||
| *.dll binary |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is really only for windows? I have never had this problem on a mac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
100%, I had fixed it a long time ago, but now have 4 copies of grails-core across a few machines and ran into it again.