Skip to content

Bump Java baseline from 17 to 21 for Grails 8 #1216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jamesfredley wants to merge 1 commit into from
Closed

Bump Java baseline from 17 to 21 for Grails 8 #1216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/gradle.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
- name: "☕️ Setup JDK"
uses: actions/setup-java@v4
with:
java-version: 17
java-version: 21
Copy link

Copilot AI Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reproducibility and to keep CI aligned with the pinned versions used elsewhere (e.g., release.yml uses JAVA_VERSION: 21.0.10 and .sdkmanrc pins 21.0.10-librca), consider pinning actions/setup-java to the same patch version (e.g., 21.0.10) instead of the floating major 21. This reduces the risk of CI behavior changing unexpectedly when a new 21.x patch is released.

Copilot uses AI. Check for mistakes.
distribution: liberica
- name: "🐘 Setup Gradle"
uses: gradle/actions/setup-gradle@0723195856401067f7a2779048b490ace7a47d7c # v5.0.2
Expand All @@ -64,7 +64,7 @@ jobs:
- name: "☕️ Setup JDK"
uses: actions/setup-java@v4
with:
java-version: 17
java-version: 21
Copy link

Copilot AI Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reproducibility and to keep CI aligned with the pinned versions used elsewhere (e.g., release.yml uses JAVA_VERSION: 21.0.10 and .sdkmanrc pins 21.0.10-librca), consider pinning actions/setup-java to the same patch version (e.g., 21.0.10) instead of the floating major 21. This reduces the risk of CI behavior changing unexpectedly when a new 21.x patch is released.

Copilot uses AI. Check for mistakes.
distribution: liberica
- name: "🐘 Setup Gradle"
uses: gradle/actions/setup-gradle@0723195856401067f7a2779048b490ace7a47d7c # v5.0.2
Expand All @@ -90,7 +90,7 @@ jobs:
- name: "☕️ Setup JDK"
uses: actions/setup-java@v4
with:
java-version: 17
java-version: 21
Copy link

Copilot AI Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reproducibility and to keep CI aligned with the pinned versions used elsewhere (e.g., release.yml uses JAVA_VERSION: 21.0.10 and .sdkmanrc pins 21.0.10-librca), consider pinning actions/setup-java to the same patch version (e.g., 21.0.10) instead of the floating major 21. This reduces the risk of CI behavior changing unexpectedly when a new 21.x patch is released.

Copilot uses AI. Check for mistakes.
distribution: liberica
- name: "🐘 Setup Gradle"
uses: gradle/actions/setup-gradle@0723195856401067f7a2779048b490ace7a47d7c # v5.0.2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/rat.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
uses: actions/setup-java@v4
with:
distribution: liberica
java-version: 17
java-version: 21
Copy link

Copilot AI Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as CI: consider pinning java-version to the exact patch level used for releases (21.0.10) to keep RAT runs consistent over time and aligned with release.yml / .sdkmanrc.

Suggested change
java-version: 21
java-version: 21.0.10

Copilot uses AI. Check for mistakes.
- name: "🐘 Setup Gradle"
uses: gradle/actions/setup-gradle@0723195856401067f7a2779048b490ace7a47d7c # v5.0.2
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GRAILS_PUBLISH_RELEASE: true
JAVA_DISTRIBUTION: liberica
JAVA_VERSION: 17.0.17 # this must be a specific version for reproducible builds, keep it synced with .sdkmanrc
JAVA_VERSION: 21.0.10 # this must be a specific version for reproducible builds, keep it synced with .sdkmanrc
PROJECT_DESC: >
Apache Grails Spring Security adds production-ready
authentication and authorization to Apache Grails applications.
Expand Down
2 changes: 1 addition & 1 deletion .sdkmanrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
java=17.0.17-librca
java=21.0.10-librca
gradle=8.14.4
# This is here to support the test app generation in the *rest projects
grails=7.0.7
2 changes: 1 addition & 1 deletion etc/bin/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
# for testing in a container that is similar to the github action linux build environment
# run this from the root of the project
# `docker build -t grails:testing -f etc/bin/Dockerfile . && docker run -it --rm -v $(pwd):/home/groovy/project grails:testing bash`
FROM bellsoft/liberica-openjdk-debian:17.0.17
FROM bellsoft/liberica-openjdk-debian:21.0.10

USER root
RUN apt-get update && apt-get install -y curl unzip coreutils libdigest-sha-perl gpg vim sudo psmisc locales groovy rsync
Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
#
projectVersion=8.0.0-SNAPSHOT
grailsVersion=8.0.0-SNAPSHOT
javaVersion=17
javaVersion=21

unboundidLdapSdkVersion=7.0.3
apacheDsVersion=1.5.4
Expand Down
Loading