[#11728] feat(iceberg-rest): Add register view support for IRC#11729
Open
lasdf1234 wants to merge 1 commit into
Open
[#11728] feat(iceberg-rest): Add register view support for IRC#11729lasdf1234 wants to merge 1 commit into
lasdf1234 wants to merge 1 commit into
Conversation
Implement register view dispatching, events, REST endpoint wiring, and tests so the Iceberg REST catalog exposes the register view API. Co-authored-by: Cursor <cursoragent@cursor.com>
Code Coverage Report
Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add Iceberg REST Catalog
register-viewsupport to Gravitino IRC, aligned with the existingregister-tableflow:POST .../namespaces/{namespace}/register-viewinIcebergNamespaceOperations.registerViewthrough the view dispatcher chain (IcebergViewHookDispatcher→IcebergViewEventDispatcher→IcebergViewOperationExecutor→IcebergCatalogWrapper→ IcebergCatalogHandlers.registerView).register-table).IcebergRegisterViewPreEvent, success/failure events,OperationType).Endpoint.V1_REGISTER_VIEWin IRC config.Fix: #11728
Why are the changes needed?
Iceberg REST API defines
register-viewfor registering existing view metadata, but Gravitino IRC only supportedregister-table. This gap blocks view import/migration workflows and leaves IRC view endpoint coverage incomplete.Does this PR introduce any user-facing change?
Yes.
POST /v1/{prefix}namespaces/{namespace}/register-view./v1/confignow includesV1_REGISTER_VIEWin the advertised endpoints list.How was this patch tested?
./gradlew :iceberg:iceberg-rest-server:test --tests org.apache.gravitino.iceberg.service.rest.TestIcebergViewOperations -PskipITs./gradlew :iceberg:iceberg-rest-server:test --tests org.apache.gravitino.iceberg.service.dispatcher.TestIcebergViewHookDispatcher -PskipITs./gradlew :iceberg:iceberg-rest-server:test --tests org.apache.gravitino.iceberg.service.dispatcher.TestIcebergViewOperationExecutor -PskipITs