[#11751] test(trino-connector): Enable Iceberg MySQL JDBC integration test#11752
Open
diqiu50 wants to merge 6 commits into
Open
[#11751] test(trino-connector): Enable Iceberg MySQL JDBC integration test#11752diqiu50 wants to merge 6 commits into
diqiu50 wants to merge 6 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.
Enables the Iceberg MySQL JDBC integration test path by passing through Iceberg JDBC schema version configuration and preparing the MySQL backend schema needed by the JDBC catalog.
Changes:
- Add support for forwarding
jdbc-schema-version(e.g.,V1) into Trino Iceberg JDBC catalog properties. - Extend unit test coverage to validate the new schema-version mapping.
- Add MySQL init DDL to create the Iceberg JDBC catalog tables and update the MySQL catalog prepare SQL to include schema version.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| trino-connector/trino-connector/src/test/java/org/apache/gravitino/trino/connector/catalog/iceberg/TestIcebergCatalogPropertyConverter.java | Adds assertions and input properties for jdbc-schema-version mapping. |
| trino-connector/trino-connector/src/main/java/org/apache/gravitino/trino/connector/catalog/iceberg/IcebergCatalogPropertyConverter.java | Forwards jdbc-schema-version into iceberg.jdbc-catalog.schema-version. |
| trino-connector/integration-test/src/test/resources/trino-ci-testset/testsets/lakehouse-iceberg/ignored/catalog_iceberg_mysql_prepare.sql | Adds jdbc-schema-version to the MySQL Iceberg catalog creation SQL (currently under ignored/). |
| integration-test-common/docker-script/init/mysql/init.sql | Creates iceberg_db and required Iceberg JDBC catalog tables in MySQL init script. |
Code Coverage Report
Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Enable the Trino connector Iceberg MySQL JDBC integration test.
Why are the changes needed?
The Iceberg MySQL JDBC test was ignored and not covered by the Trino connector integration test.
Fix: #11751
Does this PR introduce any user-facing change?
No.
How was this patch tested?
./gradlew :trino-connector:trino-connector:test --tests org.apache.gravitino.trino.connector.catalog.iceberg.TestIcebergCatalogPropertyConverter -PskipITs -PskipDockerTests=true./gradlew :trino-connector:trino-connector-473-478:assemble -PskipITs -PskipDockerTests=true./trino-connector/integration-test/trino-test-tools/trino_integration_test.sh --auto=all --test_set=lakehouse-iceberg --catalog=iceberg_mysql