[#4211] fix(catalog-jdbc): Harden database SQL generation against injection#11780
Draft
JandyTenedora wants to merge 3 commits into
Draft
[#4211] fix(catalog-jdbc): Harden database SQL generation against injection#11780JandyTenedora wants to merge 3 commits into
JandyTenedora wants to merge 3 commits into
Conversation
JandyTenedora
force-pushed
the
jandyt/fix-sql-injection-drop-database-validation
branch
2 times, most recently
from
00fb195 to
7f4edee
Compare
JandyTenedora
changed the title
JandyTenedora
force-pushed
the
jandyt/fix-sql-injection-drop-database-validation
branch
2 times, most recently
from
2e05a2e to
1a47603
Compare
Contributor
Author
Reran |
…ck-quoted drop SQL Add validateBacktickQuotedIdentifier() in JdbcDatabaseOperations to reject database names containing SQL metacharacters before they are embedded in backtick-quoted DROP DATABASE statements. Applied to all JDBC catalog overrides that use backtick quoting (MySQL, OceanBase, Doris, StarRocks, ClickHouse).
JandyTenedora
force-pushed
the
jandyt/fix-sql-injection-drop-database-validation
branch
from
07b4fba to
e4daa5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add
validateBacktickQuotedIdentifier()inJdbcDatabaseOperationsto reject database names containing SQL metacharacters before they are embedded in backtick-quotedDROP DATABASEstatements. Applied to all JDBC catalog overrides that use backtick quoting (MySQL, OceanBase via parent, Doris, StarRocks, ClickHouse).Why are the changes needed?
generateDropDatabaseSqlbuilds SQL via string formatting with backtick quoting. A name containing backticks can break out of the identifier and inject arbitrary SQL. The upstreamSchemaNormalizeDispatchervalidates names today, but callingJdbcDatabaseOperations.delete()directly bypasses that validation.Fix: #4211
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added unit tests for drop-path validation in
TestJdbcDatabaseOperations,TestClickHouseDatabaseOperations,TestDorisDatabaseOperationsSqlGeneration, andTestStarRocksDatabaseOperationsSqlGeneration— covering valid names, null, empty, SQL injection strings, spaces, and overlength names.