GROOVY-12011: groovy-csv: clarify when dates can retain rich types vs…#2534
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2534 +/- ##
==================================================
- Coverage 68.1437% 68.1356% -0.0081%
+ Complexity 32755 32754 -1
==================================================
Files 1499 1499
Lines 125228 125234 +6
Branches 22604 22604
==================================================
- Hits 85335 85329 -6
- Misses 32381 32389 +8
- Partials 7512 7516 +4
🚀 New features to boost your workflow:
|
✅ All tests passed ✅🏷️ Commit: 26abfca Learn more about TestLens at testlens.app. |
There was a problem hiding this comment.
Pull request overview
This PR updates the optional groovy-csv module to clarify and support typed java.time handling versus untyped CSV string parsing.
Changes:
- Adds a shared Jackson
CsvMapperconfigured withJavaTimeModule. - Adds temporal round-trip and untyped string-path tests.
- Updates the CSV user guide and adds the JSR-310 Jackson dependency.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
subprojects/groovy-csv/build.gradle |
Adds jackson-datatype-jsr310 dependency. |
subprojects/groovy-csv/src/main/java/groovy/csv/CsvSlurper.java |
Centralizes mapper construction with Java time support. |
subprojects/groovy-csv/src/main/java/groovy/csv/CsvBuilder.java |
Reuses the shared mapper for CSV writing. |
subprojects/groovy-csv/src/spec/test/groovy/csv/CsvBuilderTest.groovy |
Adds temporal typed/untyped behavior tests. |
subprojects/groovy-csv/src/spec/doc/csv-userguide.adoc |
Documents temporal typed parsing/writing behavior. |
… when handled as Strings
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



… when handled as Strings