Skip to content

GROOVY-12011: groovy-csv: clarify when dates can retain rich types vs…#2534

Merged
paulk-asert merged 1 commit into
apache:masterfrom
paulk-asert:groovy12011
May 15, 2026
Merged

GROOVY-12011: groovy-csv: clarify when dates can retain rich types vs…#2534
paulk-asert merged 1 commit into
apache:masterfrom
paulk-asert:groovy12011

Conversation

@paulk-asert
Copy link
Copy Markdown
Contributor

… when handled as Strings

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.1356%. Comparing base (94ae84d) to head (834e10e).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##               master      #2534        +/-   ##
==================================================
- Coverage     68.1437%   68.1356%   -0.0081%     
+ Complexity      32755      32754         -1     
==================================================
  Files            1499       1499                
  Lines          125228     125234         +6     
  Branches        22604      22604                
==================================================
- Hits            85335      85329         -6     
- Misses          32381      32389         +8     
- Partials         7512       7516         +4     
Files with missing lines Coverage Δ
...roovy-csv/src/main/java/groovy/csv/CsvBuilder.java 65.2174% <100.0000%> (ø)
...roovy-csv/src/main/java/groovy/csv/CsvSlurper.java 67.2131% <100.0000%> (+3.5767%) ⬆️

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@testlens-app
Copy link
Copy Markdown

testlens-app Bot commented May 15, 2026

✅ All tests passed ✅

🏷️ Commit: 26abfca
▶️ Tests: 81193 executed
⚪️ Checks: 28/28 completed


Learn more about TestLens at testlens.app.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the optional groovy-csv module to clarify and support typed java.time handling versus untyped CSV string parsing.

Changes:

  • Adds a shared Jackson CsvMapper configured with JavaTimeModule.
  • Adds temporal round-trip and untyped string-path tests.
  • Updates the CSV user guide and adds the JSR-310 Jackson dependency.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
subprojects/groovy-csv/build.gradle Adds jackson-datatype-jsr310 dependency.
subprojects/groovy-csv/src/main/java/groovy/csv/CsvSlurper.java Centralizes mapper construction with Java time support.
subprojects/groovy-csv/src/main/java/groovy/csv/CsvBuilder.java Reuses the shared mapper for CSV writing.
subprojects/groovy-csv/src/spec/test/groovy/csv/CsvBuilderTest.groovy Adds temporal typed/untyped behavior tests.
subprojects/groovy-csv/src/spec/doc/csv-userguide.adoc Documents temporal typed parsing/writing behavior.

Comment thread subprojects/groovy-csv/src/main/java/groovy/csv/CsvSlurper.java Outdated
Comment thread subprojects/groovy-csv/build.gradle
Comment thread subprojects/groovy-csv/src/spec/doc/csv-userguide.adoc
Comment thread subprojects/groovy-csv/build.gradle
@sonarqubecloud
Copy link
Copy Markdown

@paulk-asert paulk-asert merged commit cbd0ac5 into apache:master May 15, 2026
41 of 43 checks passed
@paulk-asert paulk-asert deleted the groovy12011 branch May 15, 2026 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants