GROOVY-12010: Graduate groovy-toml from incubating to stable#2535
Open
paulk-asert wants to merge 1 commit into
Open
GROOVY-12010: Graduate groovy-toml from incubating to stable#2535paulk-asert wants to merge 1 commit into
paulk-asert wants to merge 1 commit into
Conversation
✅ All tests passed ✅🏷️ Commit: fc6df8e Learn more about TestLens at testlens.app. |
There was a problem hiding this comment.
Pull request overview
Updates groovy-toml’s typed read/write path to support Java 8+ date/time types via Jackson JSR-310, and documents the difference between typed vs untyped parsing for TOML temporal values.
Changes:
- Configure typed parsing (
parseAs/parseTextAs) to use aTomlMapperwithJavaTimeModuleand time-related Jackson features disabled for better temporal fidelity. - Route
TomlBuilder.toTomlthrough the same configured mapper to enable temporal round-tripping. - Update the TOML user guide and add spec tests covering typed temporal round-trip and documenting the untyped temporal-as-String limitation.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| subprojects/groovy-toml/src/spec/test/groovy/toml/TomlParserTest.groovy | Adds typed temporal round-trip test and pins untyped temporal values as String. |
| subprojects/groovy-toml/src/spec/doc/toml-userguide.adoc | Updates type mapping docs and adds a section describing typed temporal fidelity. |
| subprojects/groovy-toml/src/main/java/groovy/toml/TomlSlurper.java | Introduces a configured TomlMapper (JSR-310 + feature flags) for typed parsing. |
| subprojects/groovy-toml/src/main/java/groovy/toml/TomlBuilder.java | Uses the same configured mapper for typed writing via toToml. |
| subprojects/groovy-toml/build.gradle | Adds jackson-datatype-jsr310 dependency needed for Java time support. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2535 +/- ##
==================================================
+ Coverage 68.1437% 68.1476% +0.0039%
- Complexity 32755 32761 +6
==================================================
Files 1499 1499
Lines 125228 125234 +6
Branches 22604 22604
==================================================
+ Hits 85335 85344 +9
+ Misses 32381 32378 -3
Partials 7512 7512
🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



No description provided.