Skip to content

GROOVY-12010: Graduate groovy-toml from incubating to stable#2535

Open
paulk-asert wants to merge 1 commit into
apache:masterfrom
paulk-asert:groovy12010
Open

GROOVY-12010: Graduate groovy-toml from incubating to stable#2535
paulk-asert wants to merge 1 commit into
apache:masterfrom
paulk-asert:groovy12010

Conversation

@paulk-asert
Copy link
Copy Markdown
Contributor

No description provided.

@testlens-app
Copy link
Copy Markdown

testlens-app Bot commented May 15, 2026

✅ All tests passed ✅

🏷️ Commit: fc6df8e
▶️ Tests: 80739 executed
⚪️ Checks: 28/28 completed


Learn more about TestLens at testlens.app.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates groovy-toml’s typed read/write path to support Java 8+ date/time types via Jackson JSR-310, and documents the difference between typed vs untyped parsing for TOML temporal values.

Changes:

  • Configure typed parsing (parseAs/parseTextAs) to use a TomlMapper with JavaTimeModule and time-related Jackson features disabled for better temporal fidelity.
  • Route TomlBuilder.toToml through the same configured mapper to enable temporal round-tripping.
  • Update the TOML user guide and add spec tests covering typed temporal round-trip and documenting the untyped temporal-as-String limitation.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
subprojects/groovy-toml/src/spec/test/groovy/toml/TomlParserTest.groovy Adds typed temporal round-trip test and pins untyped temporal values as String.
subprojects/groovy-toml/src/spec/doc/toml-userguide.adoc Updates type mapping docs and adds a section describing typed temporal fidelity.
subprojects/groovy-toml/src/main/java/groovy/toml/TomlSlurper.java Introduces a configured TomlMapper (JSR-310 + feature flags) for typed parsing.
subprojects/groovy-toml/src/main/java/groovy/toml/TomlBuilder.java Uses the same configured mapper for typed writing via toToml.
subprojects/groovy-toml/build.gradle Adds jackson-datatype-jsr310 dependency needed for Java time support.

Comment thread subprojects/groovy-toml/src/main/java/groovy/toml/TomlSlurper.java Outdated
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.1476%. Comparing base (94ae84d) to head (e6f54e6).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##               master      #2535        +/-   ##
==================================================
+ Coverage     68.1437%   68.1476%   +0.0039%     
- Complexity      32755      32761         +6     
==================================================
  Files            1499       1499                
  Lines          125228     125234         +6     
  Branches        22604      22604                
==================================================
+ Hits            85335      85344         +9     
+ Misses          32381      32378         -3     
  Partials         7512       7512                
Files with missing lines Coverage Δ
...vy-toml/src/main/java/groovy/toml/TomlBuilder.java 75.0000% <100.0000%> (ø)
...vy-toml/src/main/java/groovy/toml/TomlSlurper.java 82.6087% <100.0000%> (+6.1381%) ⬆️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants