GUACAMOLE-2221: fix RDP busy-loop on transport failure#635
Open
pwgcz wants to merge 1 commit intoapache:mainfrom
Open
GUACAMOLE-2221: fix RDP busy-loop on transport failure#635pwgcz wants to merge 1 commit intoapache:mainfrom
pwgcz wants to merge 1 commit intoapache:mainfrom
Conversation
When an RDP connection hits a transport-level failure (for example, a certificate error), the inner event loop in rdp.c can spin at 100% CPU. This happens because the error state in wait_result gets overwritten. When the issue occurs, guac_rdp_handle_events() sets wait_result to -1, but the loop doesn’t exit immediately. In the next iteration, the while condition assigns wait_result from rdp_guac_client_wait_for_events() effectively clearing the error flag. As a result, the loop never observes the transport failure and continues polling, spinning the CPU. Fix: break out of the loop immediately after guac_rdp_handle_events() fails, so we stop processing when FreeRDP reports a connection error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an RDP connection hits a transport-level
failure (for example, a certificate error), the
inner event loop in rdp.c can spin at 100% CPU.
This happens because the error state in
wait_result gets overwritten. When the issue
occurs, guac_rdp_handle_events() sets wait_result
to -1, but the loop doesn’t exit immediately. In
the next iteration, the while condition assigns
wait_result from rdp_guac_client_wait_for_events()
effectively clearing the error flag. As a result,
the loop never observes the transport failure and
continues polling, spinning the CPU.
Fix: break out of the loop immediately after
guac_rdp_handle_events() fails, so we stop
processing when FreeRDP reports a connection
error.