feat(table): classify deletion vectors in scan planning#855
Merged
zeroshade merged 2 commits intoapache:mainfrom Apr 7, 2026
Merged
feat(table): classify deletion vectors in scan planning#855zeroshade merged 2 commits intoapache:mainfrom
zeroshade merged 2 commits intoapache:mainfrom
Conversation
Separate deletion vectors from regular positional delete files during scan planning. DVs are identified by having ReferencedDataFile set on a positional delete manifest entry (Iceberg v3 spec). - Add dvEntries bucket to manifestEntries with isDeletionVector() helper - In collectManifestEntries: route DV entries separately from pos deletes - Add DeletionVectorFiles field to FileScanTask - Index DVs by referenced data file path for O(1) matching in PlanFiles - Unit tests for classification, matching, and FileScanTask field Part of apache#589 (v3 deletion vector support).
laskoviymishka
force-pushed
the
feat/dv-scan-planning
branch
from
7a47cb5 to
139e283
Compare
zeroshade
requested changes
Apr 7, 2026
| File iceberg.DataFile | ||
| DeleteFiles []iceberg.DataFile // positional delete files | ||
| EqualityDeleteFiles []iceberg.DataFile // equality delete files | ||
| DeletionVectorFiles []iceberg.DataFile // deletion vectors (puffin files) |
Member
There was a problem hiding this comment.
since the actual scanner will ignore these, we should probably also update the scanner to error if this is non-empty just so people don't think it's working.
Separate deletion vectors from regular positional delete files during scan planning. DVs are identified by having ReferencedDataFile set on a positional delete manifest entry (Iceberg v3 spec). - Add dvEntries bucket to manifestEntries with isDeletionVector() helper - In collectManifestEntries: route DV entries separately from pos deletes - Add DeletionVectorFiles field to FileScanTask - Index DVs by referenced data file path for O(1) matching in PlanFiles - Scanner errors if DeletionVectorFiles is non-empty (read not yet implemented) - Unit tests for classification, matching, and FileScanTask field Part of apache#589 (v3 deletion vector support).
laskoviymishka
force-pushed
the
feat/dv-scan-planning
branch
from
139e283 to
f0dec1a
Compare
zeroshade
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separate deletion vectors from regular positional delete files during scan planning. DVs are identified by having ReferencedDataFile set on a positional delete manifest entry (Iceberg v3 spec).
Part of #589 (v3 deletion vector support).