Conversation
|
Thanks for adding these @rambleraptor. I think it would be nice to:
|
|
@Fokko tests added! The tests caught a handful of Pydantic issues (thought they would've been caught at runtime...), so there's a couple changes sprinkled in the models. |
6a3a9fd to
5be3e74
Compare
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that's incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
Closes #2302
Rationale for this change
This adds the models for server-side planning. There's a lot of model-related code (the requests + responses are large!), so I'm just adding the models now. I'll add the endpoints in a separate PR.
Are these changes tested?
No tests needed, just new models.
Are there any user-facing changes?
Nothing yet, the endpoints will be in a separate PR.