Skip to content

Server-side planning models#2435

Closed
rambleraptor wants to merge 8 commits intoapache:mainfrom
rambleraptor:server_side_planning
Closed

Server-side planning models#2435
rambleraptor wants to merge 8 commits intoapache:mainfrom
rambleraptor:server_side_planning

Conversation

@rambleraptor
Copy link
Copy Markdown
Contributor

@rambleraptor rambleraptor commented Sep 8, 2025

Closes #2302

Rationale for this change

This adds the models for server-side planning. There's a lot of model-related code (the requests + responses are large!), so I'm just adding the models now. I'll add the endpoints in a separate PR.

Are these changes tested?

No tests needed, just new models.

Are there any user-facing changes?

Nothing yet, the endpoints will be in a separate PR.

@rambleraptor rambleraptor changed the title Added a whole bunch of models Server-side planning models Sep 9, 2025
@Fokko
Copy link
Copy Markdown
Contributor

Fokko commented Sep 11, 2025

Thanks for adding these @rambleraptor. I think it would be nice to:

  • See if we can combine already existing classes like Transform to avoid duplication.
  • Add some tests to see if we can (de)serialize the payload.

@rambleraptor rambleraptor requested a review from Fokko September 11, 2025 19:39
@rambleraptor
Copy link
Copy Markdown
Contributor Author

@Fokko tests added! The tests caught a handful of Pydantic issues (thought they would've been caught at runtime...), so there's a couple changes sprinkled in the models.

@rambleraptor rambleraptor requested a review from Fokko September 18, 2025 00:15
@github-actions
Copy link
Copy Markdown

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that's incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Mar 18, 2026
@github-actions
Copy link
Copy Markdown

This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

REST: Add objects for server side planning

3 participants