Skip to content

Add tests for Schema Evolution on Catalogs#2478

Closed
rambleraptor wants to merge 7 commits intoapache:mainfrom
rambleraptor:schema_update_catalog_tests
Closed

Add tests for Schema Evolution on Catalogs#2478
rambleraptor wants to merge 7 commits intoapache:mainfrom
rambleraptor:schema_update_catalog_tests

Conversation

@rambleraptor
Copy link
Copy Markdown
Contributor

Rationale for this change

PyIceberg is missing a variety of Catalog Tests compared to the Java implementation. This adds 3 different tests for schema evolution to help match the Java library coverage.

Are these changes tested?

Tests should pass.

Are there any user-facing changes?

Just tests.

Copy link
Copy Markdown
Contributor

@gabeiglio gabeiglio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! the tests are looking good! Left some small comments 👍🏼

Comment on lines +403 to +405
table.update_schema().add_column("col1", StringType()).add_column("col2", StringType()).add_column(
"col3", StringType()
).commit()
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit to format for better readability (if the linter allows it)

Suggested change
table.update_schema().add_column("col1", StringType()).add_column("col2", StringType()).add_column(
"col3", StringType()
).commit()
table.update_schema()
.add_column("col1", StringType())
.add_column("col2", StringType())
.add_column( "col3", StringType())
.commit()

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linter deeply does not like this (even with the backslashes to make it syntactically correct)

@rambleraptor rambleraptor requested a review from Fokko September 22, 2025 22:06
@rambleraptor rambleraptor force-pushed the schema_update_catalog_tests branch from deb1b89 to 839e774 Compare September 22, 2025 22:07
rambleraptor and others added 5 commits October 7, 2025 11:43
Co-authored-by: Fokko Driesprong <fokko@apache.org>
Co-authored-by: Fokko Driesprong <fokko@apache.org>
@saul-data
Copy link
Copy Markdown

Please add a test that adds data to a schema after evolution, you will notice it doesn't pick up the latest schema: #2467

@github-actions
Copy link
Copy Markdown

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that's incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Mar 18, 2026
@github-actions
Copy link
Copy Markdown

This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants