Add tests for Schema Evolution on Catalogs#2478
Add tests for Schema Evolution on Catalogs#2478rambleraptor wants to merge 7 commits intoapache:mainfrom
Conversation
gabeiglio
left a comment
There was a problem hiding this comment.
Thanks for the PR! the tests are looking good! Left some small comments 👍🏼
| table.update_schema().add_column("col1", StringType()).add_column("col2", StringType()).add_column( | ||
| "col3", StringType() | ||
| ).commit() |
There was a problem hiding this comment.
small nit to format for better readability (if the linter allows it)
| table.update_schema().add_column("col1", StringType()).add_column("col2", StringType()).add_column( | |
| "col3", StringType() | |
| ).commit() | |
| table.update_schema() | |
| .add_column("col1", StringType()) | |
| .add_column("col2", StringType()) | |
| .add_column( "col3", StringType()) | |
| .commit() |
There was a problem hiding this comment.
The linter deeply does not like this (even with the backslashes to make it syntactically correct)
deb1b89 to
839e774
Compare
Co-authored-by: Fokko Driesprong <fokko@apache.org>
Co-authored-by: Fokko Driesprong <fokko@apache.org>
|
Please add a test that adds data to a schema after evolution, you will notice it doesn't pick up the latest schema: #2467 |
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that's incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
Rationale for this change
PyIceberg is missing a variety of Catalog Tests compared to the Java implementation. This adds 3 different tests for schema evolution to help match the Java library coverage.
Are these changes tested?
Tests should pass.
Are there any user-facing changes?
Just tests.