Core: Fix bin packing when target file size is smaller than a row #2844
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change do?
When
write.target-file-size-bytesis smaller than a single row, bin packing computed a 0 row chunk size and PyArrow raised a ValueError. This change clamps the chunk size to at least 1, so writes still succeed (one row per batch/file when needed).Why is this needed?
Fixes a crash when users set a small target file size and attempt to write large records.
How was this tested?
Closes #2795