-
Notifications
You must be signed in to change notification settings - Fork 411
infra: add python 3.13 support #2863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Add Python 3.13 to Github Actions workflow matrices - Update CIBW_PROJECT_REQUIRES - Add classifier to pyproject.toml - Update ray dependency with python 3.13 constraint - Fix InMemoryCatalog to close connections - Add pytest filter to ignore rest of 3.13 SQLite Resource Warnings
| # Ignore 32 bit architectures | ||
| CIBW_ARCHS: "auto64" | ||
| CIBW_PROJECT_REQUIRES_PYTHON: ">=3.10" | ||
| CIBW_PROJECT_REQUIRES_PYTHON: ">=3.10,<=3.13" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this exclude 3.13.1? If so we should probably make this <3.14
geruh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for driving this forward @kevinjqliu this change has looked good to me! I was able to run the test locally against Python 3.13.3 and saw no problems. Just have a minor comment
Rationale for this change
Closes #1372, #2530
Based on #1377, #2536, #2658
Adds Python 3.13 throughout the repo
Upgrade
rayto a version built with python 3.13Add
filterwarningsforResourceWarningscoming fromsqliteandrayfor now, will follow up with a proper fixAre these changes tested?
Yes
Are there any user-facing changes?