Skip to content

Adding a sort order validation test#2937

Closed
rambleraptor wants to merge 2 commits intoapache:mainfrom
rambleraptor:rest_catalog_test_sort_order
Closed

Adding a sort order validation test#2937
rambleraptor wants to merge 2 commits intoapache:mainfrom
rambleraptor:rest_catalog_test_sort_order

Conversation

@rambleraptor
Copy link
Copy Markdown
Contributor

Rationale for this change

This test shows the error that iceberg-rest-fixture is throwing for a Sort Order that references a field that doesn't exist.

Are these changes tested?

Are there any user-facing changes?

@Fokko
Copy link
Copy Markdown
Contributor

Fokko commented Jan 22, 2026

What are we testing here from a PyIceberg perspective? I think this should be part of the Rest Fixtures tests?

@rambleraptor rambleraptor marked this pull request as draft January 22, 2026 15:11
@rambleraptor
Copy link
Copy Markdown
Contributor Author

I've moved this over to a draft.

I built this test mostly as a POC for https://lists.apache.org/thread/2h33jt9flnxctjtwsl3od9yxxbhmcvov. Writing it in Python makes it very obvious what JSON is being returned.

@Fokko
Copy link
Copy Markdown
Contributor

Fokko commented Jan 23, 2026

Ah, I see. That makes sense. Thanks for the context 👍

@github-actions
Copy link
Copy Markdown

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that's incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Mar 18, 2026
@github-actions
Copy link
Copy Markdown

This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants