fix: allow missing sequence-number in v2 snapshots for v1-upgraded tables#2127
Open
jembishop wants to merge 1 commit intoapache:mainfrom
Open
fix: allow missing sequence-number in v2 snapshots for v1-upgraded tables#2127jembishop wants to merge 1 commit intoapache:mainfrom
jembishop wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
jembishop
force-pushed
the
fix/v2-snapshot-sequence-number
branch
from
10eb184 to
734dc8f
Compare
Contributor
Author
|
@CTTY could I get a rereview on this please? |
Collaborator
|
cc @blackmwk to take a look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Didn't make an issue sorry. Very small change.
What changes are included in this PR?
After upgrading to v2 table I got complaints that this field does not exist, so
Added a default for sequence number for this struct.
I think this should be ok, as this is treated as 0 for iceberg v1 wrt to v2 compat in other contexts? But would like some confirmation.
Are these changes tested?
Tested that it fixes my problem, yes.