Skip to content

chore(deps): fix audit check and disable inherited aws sdk default features#2274

Merged
blackmwk merged 4 commits intoapache:mainfrom
maybe-vibe:audit/aws-sdk-default-features
Mar 23, 2026
Merged

chore(deps): fix audit check and disable inherited aws sdk default features#2274
blackmwk merged 4 commits intoapache:mainfrom
maybe-vibe:audit/aws-sdk-default-features

Conversation

@maybe-vibe
Copy link
Contributor

@maybe-vibe maybe-vibe commented Mar 22, 2026

Which issue does this PR close?

  • Fix the audit check by updating aws-lc-sys and rustls-webpki.
  • Avoid pulling both the legacy rustls / Hyper 0.14 stack and the newer default-https-client stack through inherited AWS SDK defaults. (AWS SDK announcement)

What changes are included in this PR?

  • Bump to aws-lc-sys>=0.39.0 and rustls-webpki>=0.103.10 to pass security audit.
  • Disable inherited AWS SDK default features for aws-sdk-glue and aws-sdk-s3tables
  • Explicitly enable default-https-client and rt-tokio
  • Bump the minimum aws-sdk-glue version to 1.85, the first version that provides default-https-client

Are these changes tested?

@blackmwk
Copy link
Contributor

Hi, @maybe-vibe I don't think we need this pr. Downstream users are free to pin higher version of glue sdk an choose features to enable/disable.

@blackmwk
Copy link
Contributor

Oh, sorry, I misunderstood the purpose, it was used for resolving the auditing failure.

@maybe-vibe
Copy link
Contributor Author

maybe-vibe commented Mar 23, 2026

Downstream users are free to ... and choose features to enable/disable.

Downstream users cannot disable the rustls feature of aws-sdk-glue which pulls in the legacy hyper 0.14 stack.

The auditing failures are about aws-lc-sys (via aws-lc-rs) and rustls-webpki, which could be updated separately; but yes both are about stale dependencies.

@blackmwk blackmwk mentioned this pull request Mar 23, 2026
@maybe-vibe maybe-vibe changed the title chore(deps): disable inherited aws sdk default features for catalog crates chore(deps): fix audit check and disable inherited aws sdk default features Mar 23, 2026
Copy link
Contributor

@blackmwk blackmwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maybe-vibe for this fix!

@blackmwk blackmwk merged commit 2820d47 into apache:main Mar 23, 2026
20 checks passed
@maybe-vibe maybe-vibe deleted the audit/aws-sdk-default-features branch March 23, 2026 03:11
blackmwk added a commit to blackmwk/iceberg-rust that referenced this pull request Mar 24, 2026
…/python

Addresses the security advisory GHSA-pwjx-qhcg-rvj4 for rustls-webpki
< 0.103.10 in the Python bindings lockfile.

This is a rebase of apache#2268 onto main which already includes the root
Cargo.lock audit fix from apache#2274 (aws-lc-sys >= 0.39.0).

Made-with: Cursor
kevinjqliu pushed a commit that referenced this pull request Mar 24, 2026
…python (#2278)

Addresses the security advisory GHSA-pwjx-qhcg-rvj4 for rustls-webpki <
0.103.10 in the Python bindings lockfile.

This is a rebase of #2268 onto main which already includes the root
Cargo.lock audit fix from #2274 (aws-lc-sys >= 0.39.0).


## Which issue does this PR close?



- Closes #.

## What changes are included in this PR?


## Are these changes tested?

ci.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants