Skip partition pruning for manifests whose spec references a dropped source column#2845
Open
anoopj wants to merge 2 commits into
Open
Skip partition pruning for manifests whose spec references a dropped source column#2845anoopj wants to merge 2 commits into
anoopj wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2844.
What changes are included in this PR?
When a scan has a predicate, planning resolves every manifest's spec partition type against the snapshot schema. Manifests written under a historical spec whose source column was later dropped (which is a legit possibility in v2+) fail that resolution, so one such manifest fails the whole scan, even when the predicate only references live columns.
This PR is the stopgap described in #2844. The longer-term fix is deriving partition types from transforms where possible (as iceberg-java does in apache/iceberg#17262), which would also restore pruning on a historical spec's still-live partition fields.
Are these changes tested?
yes. added tests