Skip to content

fix(sql): return errors for invalid pool properties#2847

Open
mattfaltyn wants to merge 1 commit into
apache:mainfrom
mattfaltyn:agent/fix-sql-pool-properties
Open

fix(sql): return errors for invalid pool properties#2847
mattfaltyn wants to merge 1 commit into
apache:mainfrom
mattfaltyn:agent/fix-sql-pool-properties

Conversation

@mattfaltyn

Copy link
Copy Markdown

Which issue does this PR close?

What changes are included in this PR?

  • Parse SQL catalog connection-pool properties without panicking.
  • Return ErrorKind::DataInvalid with the invalid property, value, and parse error.
  • Add regression coverage for pool.max-connections, pool.idle-timeout, and pool.test-before-acquire.

Are these changes tested?

  • cargo test -p iceberg-catalog-sql --all-features --lib
  • cargo fmt --all -- --check
  • cargo clippy -p iceberg-catalog-sql --all-targets --all-features -- -D warnings
  • Re-ran the issue reproducer and confirmed the malformed value returns a structured error while a valid value still initializes the catalog.

@mattfaltyn
mattfaltyn marked this pull request as ready for review July 18, 2026 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SQL catalog panics on invalid pool property values

1 participant