fix(datafusion): classify filter pushdown accurately#2848
Open
AndreaBozzo wants to merge 1 commit into
Open
Conversation
AndreaBozzo
marked this pull request as ready for review
July 18, 2026 08:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Classify DataFusion filter pushdown as
Exact,Inexact, orUnsupportedbased on whether conversion to an Iceberg predicate is lossless. Exact filters no longer require a residualFilterExec; conservative and partial conversions remain inexact, and unsafe negated partial conversions remain unsupported.Are these changes tested?
Yes. Added unit and integration coverage for exact, inexact, and unsupported classifications, and updated SQL logic test expectations.
Validated with:
cargo fmt --all -- --checkcargo clippy -p iceberg-datafusion --all-targets --all-features -- -D warningscargo test -p iceberg-datafusion --all-featurescargo test -p iceberg-sqllogictest --test sqllogictests