Spark: Fix wap branch delete scan/write to the wrong branch#15592
Open
yingjianwu98 wants to merge 1 commit intoapache:mainfrom
Open
Spark: Fix wap branch delete scan/write to the wrong branch#15592yingjianwu98 wants to merge 1 commit intoapache:mainfrom
yingjianwu98 wants to merge 1 commit intoapache:mainfrom
Conversation
yingjianwu98
changed the title
yingjianwu98
force-pushed
the
yingjianw/fix_spark_wap_branch_metadata_delete
branch
from
6a0f953 to
bed4cd2
Compare
yingjianwu98
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under certain cases, SparkTable,
deleteWhere()andcanDeleteWhere()do not resolve the WAP (Write-Audit-Publish) branch from the session configuration.This causes two issues:
canDeleteWhere()scans the wrong branch's files, so it cannot correctly determine whether the delete can be resolved at the metadata level, causing delete to fail. This is an existing issue across all spark versiondeleteWhere()commits the delete to main instead of the WAP branch, incorrectly dropping data on the main branch. I think it's a recent regression from this PR. Not a Spark expert here but based on my stack trace, I think the spark optimizer:OptimizeMetadataOnlyDeleteFromTabledoesn't have the branch information so it will always perform on the main branch.Fix: