ADLS: Throw NotFoundException for inexistent input file#15806
Open
findinpath wants to merge 1 commit intoapache:mainfrom
Open
ADLS: Throw NotFoundException for inexistent input file#15806findinpath wants to merge 1 commit intoapache:mainfrom
findinpath wants to merge 1 commit intoapache:mainfrom
Conversation
Signal to the TableOperations that there is no retry needed for files which do not exist.
findinpath
commented
Mar 28, 2026
| try { | ||
| return fileClient.openInputStream(getInputOptions(range)); | ||
| } catch (RuntimeException e) { | ||
| throwNotFoundIfPresent(e, location); |
Contributor
Author
There was a problem hiding this comment.
A file may be removed may happen also WHILE being read and we could have as well situations in which NotFoundException should be thrown.
I didn't add this handling though in the read(..) methods yet because I consider the scenario rather exotic (and the next retry would catch anyway the fact that the file is not found).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signal to the TableOperations that there is no retry needed for files which do not exist.
Relates to #15734
Fixes #15760
Additional context
Relevant
apache/icebergcode using this changeiceberg/core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java
Lines 194 to 200 in a114e95