Skip to content

Spec: Clarify boolean predicate constants#17120

Open
manuzhang wants to merge 1 commit into
apache:mainfrom
manuzhang:codex/expression-boolean-predicate-objects
Open

Spec: Clarify boolean predicate constants#17120
manuzhang wants to merge 1 commit into
apache:mainfrom
manuzhang:codex/expression-boolean-predicate-objects

Conversation

@manuzhang

@manuzhang manuzhang commented Jul 7, 2026

Copy link
Copy Markdown
Member

This clarifies the expression spec JSON serialization for boolean predicate constants.

The predicate grammar now serializes true and false constants as predicate objects, for example { "type": "true" }, instead of bare JSON booleans. This avoids ambiguity with boolean literal value expressions.

Addresses #16652 (comment)


AI Disclosure

  • Model: GPT-5
  • Platform/Tool: OpenAI Codex
  • Human Oversight: reviewed
  • Prompt Summary: Create a follow-up PR for a review comment suggesting object serialization for true/false expression predicates.

Clarify that true and false predicate constants serialize as predicate objects to avoid ambiguity with boolean literal values.

Generated-by: Codex

Co-authored-by: Codex <codex@openai.com>
@github-actions github-actions Bot added the Specification Issues that may introduce spec changes. label Jul 7, 2026
@manuzhang manuzhang requested a review from Copilot July 7, 2026 04:09

This comment was marked as resolved.

@manuzhang manuzhang marked this pull request as ready for review July 7, 2026 04:15
@manuzhang manuzhang requested a review from rdblue July 7, 2026 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Specification Issues that may introduce spec changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants