Skip to content

Core: Fix OAuthTokenResponse.addScope error to show the invalid scope #17126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anxkhn wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −1
Open

Core: Fix OAuthTokenResponse.addScope error to show the invalid scope #17126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/java/org/apache/iceberg/rest/responses/OAuthTokenResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ public Builder setExpirationInSeconds(int durationInSeconds) {
}

public Builder addScope(String scope) {
Preconditions.checkArgument(OAuth2Util.isValidScopeToken(scope), "Invalid scope: %s");
Preconditions.checkArgument(OAuth2Util.isValidScopeToken(scope), "Invalid scope: %s", scope);
this.scopes.add(scope);
return this;
}
Expand Down
7 changes: 7 additions & 0 deletions core/src/test/java/org/apache/iceberg/rest/responses/TestOAuthTokenResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,4 +130,11 @@ public void testFailures() {
.isInstanceOf(IllegalArgumentException.class)
.hasMessageContaining("Cannot parse to a string value: token_type: 34");
}

@Test
void invalidScopeReportsScopeValue() {

@ebyhr ebyhr Jul 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
void invalidScopeReportsScopeValue() {
void addInvalidScope() {

assertThatThrownBy(() -> OAuthTokenResponse.builder().addScope("bad scope"))
.isInstanceOf(IllegalArgumentException.class)
.hasMessage("Invalid scope: bad scope");
}
}
Loading