Add additional properties when doing conversion for hudi#714
Merged
vinishjail97 merged 3 commits intoapache:mainfrom May 30, 2025
Merged
Add additional properties when doing conversion for hudi#714vinishjail97 merged 3 commits intoapache:mainfrom
vinishjail97 merged 3 commits intoapache:mainfrom
Conversation
Contributor
Author
Contributor
Author
Contributor
|
The tests are flaky after merging the previous PR for xtable-service-> #704 |
Contributor
Author
|
@vinishjail97 Are you sure though? Im not too sure why that pr would cause a flaky test behavior for It seems like this change that was merged recently was able to run fine on the CI #669 Ill try inspecting the full raw logs but can we try rerunning the ci again for this pr to see what occurs? |
c150dc8 to
2e680ee
Compare
the-other-tim-brown
approved these changes
May 30, 2025
vinishjail97
approved these changes
May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What is the purpose of the pull request
This pr fixes several minor issues with the service which were caught in recent manual and integration testing(see IT pr https://github.com/apache/incubator-xtable/pull/716/files), in order to ensure conversion works for hudi and iceberg and with partitioned tables.
Brief change log
partition-specin theconfigurationsmap in the request.Special note
As a follow up we will need also add these changes(around parition-spec and a source-data-path) to the spec pr here: #715
Verify this pull request
Now when running with this change do not see the issue.
IT test pr when ran locally passes #716