Skip to content

Comments

avoid having both 'keep' and 'expires_at'#484

Open
raboof wants to merge 1 commit intoapache:mainfrom
raboof:avoid-keep-and-expires
Open

avoid having both 'keep' and 'expires_at'#484
raboof wants to merge 1 commit intoapache:mainfrom
raboof:avoid-keep-and-expires

Conversation

@raboof
Copy link
Member

@raboof raboof commented Feb 12, 2026

Remove 'expires_at' if there is also 'keep', since 'keep' currently takes precendence.

We'll want to remove the 'keep' entries for most of these cases eventually, but let's do that gradually to reduce impact.

See also #252

actions.yml Outdated
tag: v7.0.0
keep: true
55c2c1448f86e01eaae002a5a3a9624417608d84:
expires_at: 2050-08-01
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
expires_at: 2050-08-01
keep: true

We probably don't care about this commit ID in 24 years ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heh yeah this is a leftover, see also #483 - I'll update to reduce the likelihood of merge conflicts.

@raboof raboof force-pushed the avoid-keep-and-expires branch from 9028a2c to a65e52a Compare February 13, 2026 09:03
Remove 'expires_at' if there is also 'keep', since 'keep' currently
takes precendence.

We'll want to remove the 'keep' entries for most of these cases eventually,
but let's do that gradually to reduce impact.

See also apache#252
@raboof raboof force-pushed the avoid-keep-and-expires branch from a65e52a to d01d5c1 Compare February 13, 2026 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants