Skip to content

[To dev/1.3] Pipe: Reduced the log of processor memory control (#16989) #16996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jt2594838 merged 1 commit into from
Jan 8, 2026
Merged

[To dev/1.3] Pipe: Reduced the log of processor memory control (#16989) #16996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 12 additions & 16 deletions ...main/java/org/apache/iotdb/db/pipe/agent/task/subtask/processor/PipeProcessorSubtask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import org.apache.iotdb.commons.pipe.agent.task.progress.PipeEventCommitManager;
import org.apache.iotdb.commons.pipe.agent.task.subtask.PipeReportableSubtask;
import org.apache.iotdb.commons.pipe.event.EnrichedEvent;
import org.apache.iotdb.commons.pipe.resource.log.PipeLogger;
import org.apache.iotdb.db.pipe.agent.PipeDataNodeAgent;
import org.apache.iotdb.db.pipe.agent.task.connection.PipeEventCollector;
import org.apache.iotdb.db.pipe.event.UserDefinedEnrichedEvent;
Expand Down Expand Up @@ -188,15 +189,17 @@ protected boolean executeOnce() throws Exception {
}
decreaseReferenceCountAndReleaseLastEvent(event, shouldReport);
} catch (final PipeRuntimeOutOfMemoryCriticalException e) {
LOGGER.info(
"Temporarily out of memory in pipe event processing, will wait for the memory to release.",
e);
PipeLogger.log(
LOGGER::info,
e,
"Temporarily out of memory in pipe event processing, will wait for the memory to release.");
return false;
} catch (final Exception e) {
if (ExceptionUtils.getRootCause(e) instanceof PipeRuntimeOutOfMemoryCriticalException) {
LOGGER.info(
"Temporarily out of memory in pipe event processing, will wait for the memory to release.",
e);
PipeLogger.log(
LOGGER::info,
e,
"Temporarily out of memory in pipe event processing, will wait for the memory to release.");
return false;
}
if (!isClosed.get()) {
Expand All @@ -210,7 +213,9 @@ protected boolean executeOnce() throws Exception {
ErrorHandlingUtils.getRootCause(e).getMessage()),
e);
} else {
LOGGER.info("Exception in pipe event processing, ignored because pipe is dropped.", e);
LOGGER.info(
"Exception in pipe event processing, ignored because pipe is dropped.{}",
e.getMessage() != null ? " Message: " + e.getMessage() : "");
clearReferenceCountAndReleaseLastEvent(event);
}
}
Expand Down Expand Up @@ -282,15 +287,6 @@ public int getRegionId() {
return regionId;
}

public int getEventCount(final boolean ignoreHeartbeat) {
// Avoid potential NPE in "getPipeName"
final EnrichedEvent event =
lastEvent instanceof EnrichedEvent ? (EnrichedEvent) lastEvent : null;
return Objects.nonNull(event) && !(ignoreHeartbeat && event instanceof PipeHeartbeatEvent)
? 1
: 0;
}

//////////////////////////// Error report ////////////////////////////

@Override
Expand Down
2 changes: 1 addition & 1 deletion ...anode/src/main/java/org/apache/iotdb/db/pipe/agent/task/subtask/sink/PipeSinkSubtask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ protected boolean executeOnce() {
e);
} else {
LOGGER.info(
"Exception in pipe transfer, ignored because the connector subtask is dropped.{}",
"Exception in pipe transfer, ignored because the sink subtask is dropped.{}",
e.getMessage() != null ? " Message: " + e.getMessage() : "");
clearReferenceCountAndReleaseLastEvent(event);
}
Expand Down
Loading