[IOTDB-4769] When modifying an alias, you need to add back quotes when the alias is a special character. #7745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@lancelly Hi, Please review! |
lancelly
reviewed
Nov 3, 2022
Comment on lines
1667
to
1671
| String unWrapped = nodeName.substring(1, nodeName.length() - 1); | ||
| String unWrapped = | ||
| nodeName | ||
| .substring(1, nodeName.length() - 1) | ||
| .replace(TsFileConstant.DOUBLE_BACK_QUOTE_STRING, TsFileConstant.BACK_QUOTE_STRING); | ||
| ; |
Contributor
There was a problem hiding this comment.
This method should stay the same~
Contributor
Author
There was a problem hiding this comment.
This is to solve the problem that the double back quotes in the node path do not resolve to single quotes.
Contributor
Author
There was a problem hiding this comment.
I think the document also needs to be modified. Let me restore it here first, and then mention a new pr~
neuyilan
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
###1. When modifying a time series alias, if the alias is a real number, you need to add a back quote, otherwise an error should be reported. Now you can successfully modify the alias without adding a back quote, causing the alias to not be used normally.
Before
When an alias is used and a piece of data is written, a new time series will be created incorrectly.
After
Create Time Series and modify alias without back quotes.
Change alias with back quotes, write a piece of data
2. Fix that two back quotes in the node path do not resolve to a back quote
Before:
After: